Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(content): picking up household trash cans as a container #4718

Merged
merged 4 commits into from
Jun 8, 2024

Conversation

chaosvolt
Copy link
Member

@chaosvolt chaosvolt commented Jun 2, 2024

Purpose of change

This adds an easy obvious source of an open container that could be repurposed for storing water and the like.

Describe the solution

  1. Added item form for plastic trash cans, counting as an open container with the same size and capacity as the furniture itself has. Can also be activated to place it back down as furniture again. Fittingly it's a bit over 5 gallons, a common size for small waste baskets.
  2. Gave trash cans the deployed_furniture examine action, yielding the item form when undeployed. Updated description accordingly to reference it, and also bumped up bash results to better match the mass of the trash can when cut up.
  3. Added loose trash cans to the following itemgroups: home_hw, recycle_plastic, dollar_kitchen, and supplies_hardware.
  4. Per suggestion, added a recipe for making one from plastic using a plastic mold.

Describe alternatives you've considered

  1. Making it so you deconstruct them instead, with a random chance of also being lined with a plastic bag or plastic shopping bag. Would also need to have the placed version be a slightly different furniture so that it then can't be deconstructed for a free plastic bag, so not worth the added hassle for a tiny bit of extra flavor.
  2. Adding the classic 30-ish-gallon metal trash can as the penultimate pro wresting weapon, second only to the folding chair.
  3. Allowing clay or plastic flower pots to count as containers too, or adding recipes to fill in the drainage holes they likely have on the bottom if we decide it's too unrealismic to just let you use them as containers as-is. Planting pots without drainage holes do exist IRL, though a quick search suggests it's not ideal.

Testing

  1. Checked affected files for syntax and lint errors.
  2. Load-tested in compiled test build, confirmed that using a looks_like matching plastic flower pots gives it a wield sprite, and that it does indeed hold water as an open container should.

Additional context

goofy ahh redneck engineering
image

Checklist

@github-actions github-actions bot added the JSON related to game datas in JSON format. label Jun 2, 2024
@Lamandus
Copy link
Contributor

Lamandus commented Jun 2, 2024

since you took all steps to make it an item. Would it be too far fetched to create a recipe for it? maybe we find other uses for it later? (vehicles)

@chaosvolt
Copy link
Member Author

Could perhaps. I didn't at first since I noticed that plastic flower pots don't have a recipe but clay ones do, but could go ahead anyway.

@scarf005 scarf005 merged commit 66bb6ec into cataclysmbnteam:main Jun 8, 2024
10 checks passed
@chaosvolt chaosvolt deleted the i'm-the-trash-man branch June 8, 2024 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JSON related to game datas in JSON format.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants